Skip to content

Conversation

@AlexeySachkov
Copy link
Contributor

This is a cherry-pick of #19828

Always propagate origin value will cause bad performance.

… is enabled (intel#19828)

Always propagate origin value will cause bad performance.
@AlexeySachkov
Copy link
Contributor Author

Unexpectedly Passed Tests (1):
  SYCL :: KernelAndProgram/kernel-bundle-get-kernel-ids.cpp

That is a known XPASS

Failed Tests (3):
  SYCL :: MemorySanitizer/track-origins/check_host_usm.cpp
  SYCL :: MemorySanitizer/track-origins/check_host_usm_initialized_on_host.cpp
  SYCL :: MemorySanitizer/track-origins/check_shared_usm.cpp

That is probably related to the patch itself, I will hold off the merge until those failures are investigated

@zhaomaosu
Copy link
Contributor

Hi @AlexeySachkov, these origin track tests have been disabled in main branch https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/MemorySanitizer/track-origins/check_host_usm.cpp#L2

@AlexeySachkov
Copy link
Contributor Author

Hi @AlexeySachkov, these origin track tests have been disabled in main branch https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/MemorySanitizer/track-origins/check_host_usm.cpp#L2

The patch I'm cherry-picking was merged on Aug 28 and failing tests were disabled on Jul 24 due to driver update. That means that with an older driver (we fix the environment for release branches, at least on Linux) this patch introduces a regression and as such cannot be merged as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants