Skip to content

[SYCL] Kernel object and lambda must have the same name #20041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2025
Merged

[SYCL] Kernel object and lambda must have the same name #20041

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
829c0d3
Kernel object and lambda must have the same name
vinser52 Sep 10, 2025
19d0b9b
Minor fix
vinser52 Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions sycl/include/sycl/handler.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1467,12 +1467,13 @@ class __SYCL_EXPORT handler {
setNDRangeDescriptor(std::move(params)...);
}

setDeviceKernelInfo(std::move(Kernel));
if (lambdaAndKernelHaveEqualName<NameT>()) {
StoreLambda<NameT, KernelType, Dims, ElementType>(std::move(KernelFunc));
} else {
extractArgsAndReqs();
MKernel = detail::getSyclObjImpl(Kernel);
if (!lambdaAndKernelHaveEqualName<NameT>()) {
throw sycl::exception(
make_error_code(errc::invalid),
"the kernel name must match the name of the lambda");
}
StoreLambda<NameT, KernelType, Dims, ElementType>(std::move(KernelFunc));
processProperties<Info.IsESIMD, PropertiesT>(Props);
#endif
}
Expand Down Expand Up @@ -1926,12 +1927,15 @@ class __SYCL_EXPORT handler {
// No need to check if range is out of INT_MAX limits as it's compile-time
// known constant
setNDRangeDescriptor(range<1>{1});
setDeviceKernelInfo(std::move(Kernel));
if (lambdaAndKernelHaveEqualName<NameT>()) {
StoreLambda<NameT, KernelType, /*Dims*/ 1, void>(std::move(KernelFunc));
} else {
extractArgsAndReqs();

MKernel = detail::getSyclObjImpl(std::move(Kernel));
if (!lambdaAndKernelHaveEqualName<NameT>()) {
throw sycl::exception(
make_error_code(errc::invalid),
"the kernel name must match the name of the lambda");
}
StoreLambda<NameT, KernelType, /*Dims*/ 1, void>(std::move(KernelFunc));

#else
detail::CheckDeviceCopyable<KernelType>();
#endif
Expand Down
Loading