[SYCL][ABI Break]Removing Manifest from the offload binary structure. #20062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YuriPlyakhin
force-pushed
the
remove_manifest
branch
from
ce077b5 to
36fe1a9
Compare
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YuriPlyakhin
force-pushed
the
remove_manifest
branch
from
36fe1a9 to
6a40dc8
Compare
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
commented
Sep 17, 2025
|
|
||
| StringRef Prefix = | ||
| sys::path::stem(Binary.getMemoryBufferRef().getBufferIdentifier()); | ||
| StringRef Suffix = getImageKindName(Binary.getImageKind()); |
There was a problem hiding this comment.
not used. removed.
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
force-pushed
the
remove_manifest
branch
from
5d20892 to
c8bba33
Compare
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
srividya-sundaram
approved these changes
Sep 23, 2025
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
approved these changes
Sep 23, 2025
|
@intel/llvm-gatekeepers please consider merging |
@intel/llvm-gatekeepers , please, do not merge yet. Not approved yet by breaking change team. |
Co-authored-by: Marcos Maronas <[email protected]>
Co-authored-by: Marcos Maronas <[email protected]>
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@cperkinsintel , @aelovikov-intel , ping. Breaking change team has approved it, so I want to merge. |
|
@intel/llvm-gatekeepers , all green, please merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change main purpose is to align offload binary descriptor with the one we are upstreaming to llorg.
-fpreview-breaking-changesflag to both the clang-offload-wrapper and clang-linker-wrapper tools, allowing users to enable preview featuresclang-offload-wrapper-exe-preview.cppto verify the correct behavior of the wrapper tool when preview-breaking-changes are enabled. Existing tests have been annotated to clarify their usage in preview and non-preview modes.These changes collectively enable opt-in support for upcoming ABI breaking changes to the SYCL offload binary format, improve maintainability, and provide robust test coverage for both legacy and preview modes.