[SYCL] Remove unnecessary fallback assert impl in libdevice #20092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: jinge90 <[email protected]>
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: jinge90 <[email protected]>
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
The failures related to assert is due to OCL CPU runtime on Linux, these failures are gone if using latest OCL CPU runtime, wait for syclos pre-ci infra updates. |
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: jinge90 <[email protected]>
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Sep 17, 2025
steffenlarsen
approved these changes
Sep 17, 2025
libdevice/fallback-cassert.cpp
Outdated
| *Dst = SPIR_AssertHappenedMem; | ||
| } | ||
|
|
||
| DEVICE_EXTERN_C void __devicelib_assert_fail(const char *expr, const char *file, |
There was a problem hiding this comment.
Looking at the failures, we may still need a dummy implementation of this. The extension states:
If device has the
ext_oneapi_native_assertaspect, then its Device-Side Runtime is capable of native support of assert. If device doesn’t have the aspect, then assertions on the device will be silently ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallback assert support has been dropped in #18310.