[ESIMD] Don't always dump entry points if LLVM_ENABLE_DUMP=ON #20150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from intel#18684 in debug/release with asserts builds entry points are always dumped in ESIMDPostSplitProcessing. This is meant to be a debugging tool, but now it is spamming build logs. intel#18684 is marked as NFC, so my assumption is that this was unintentional. Guard the dump with a variable (disabled by default) so that it can be enabled for debugging, the same way as it was in sycl-post-link.cpp prior to the code move. FYI: `LLVM_ENABLE_DUMP` is an option documented to > Enable dump functions even when assertions are disabled (from [llvm/CMakeLists.txt:698](https://github.com/llvm/llvm-project/blob/32b1f167fbee28debc7527b939a6764575c854a4/llvm/CMakeLists.txt#L698)) and its typical usage is to guard the definitions of dump functions, e.g.: ```cpp class Foo { // ... void dump() const; } ``` and not to guard **calls** to such functions.
Maetveis
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Maetveis
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Maetveis
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sarnex
approved these changes
Sep 22, 2025
|
Test failures are not related Intel Arc:
This is #19468 Gen12 Preview mode
Gen12 Windows:
|
|
@intel/llvm-gatekeepers please consider merging, I believe the CI failures are unrelated. |
Maetveis
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from #18684 in debug/release with asserts builds entry points are always dumped in ESIMDPostSplitProcessing. This is meant to be a debugging tool, but now it is spamming build logs.
#18684 is marked as NFC, so my assumption is that this was unintentional.
Guard the dump with a variable (disabled by default) so that it can be enabled for debugging, the same way as it was in sycl-post-link.cpp prior to the code move.
FYI:
LLVM_ENABLE_DUMPis an option documented to(from llvm/CMakeLists.txt:698)
and its typical usage is to guard the definitions of dump functions, e.g.:
and not to guard calls to such functions.