[SYCL] Reduce scope of the SYCL2020_DISABLE_DEPRECATION_WARNINGS macro
#20155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have two kinds of deprecations in our implementation: 1. Functionality that is deprecated by the SYCL 2020 specification. It must still be supported and will only be removed in the future version of the standard. We can only remove it once we drop support for the SYCL 2020 standard all together; 2. Functionality that is deprecated by us (some non-standard API accidentally made public for whichever reason, changes to extensions, etc.). Such functionality can be removed by us way quicker and it isn't tied to the SYCL 2020 standard; By some reason, the macro which is intended to control warnings about the group (1) also controlled warnings about the group (2) and this patch fixes that. `SYCL2020_DISABLE_DEPRECATION_WARNINGS` changed it so that it **only** control warnings from the group (1). Warnings from the group (2) can only be disabled with a newly introduced internal macro `__SYCL_DISABLE_DEPRECATION_WARNINGS` which we need to reduce the noise from building `libsycl.so` and unit-tests for it which still can reference deprecated functionality from the group (2). There is no user-visible macro provided for disabling warnings from the group (2). Anyone who wants to silence those warnings should use regular `-Wno-deprecated-declarations`.
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
approved these changes
Sep 23, 2025
There was a problem hiding this comment.
There is no user-visible macro provided for disabling warnings from the group (2). Anyone who wants to silence those warnings should use regular -Wno-deprecated-declarations.
This might surprise some users, but I think this is a fair solution. I imagine some users will sniff out the new macro, but so be it.
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two kinds of deprecations in our implementation:
By some reason, the macro which is intended to control warnings about the group (1) also controlled warnings about the group (2) and this patch fixes that.
SYCL2020_DISABLE_DEPRECATION_WARNINGSchanged it so that it only control warnings from the group (1).Warnings from the group (2) can only be disabled with a newly introduced internal macro
__SYCL_DISABLE_DEPRECATION_WARNINGSwhich we need to reduce the noise from buildinglibsycl.soand unit-tests for it which still can reference deprecated functionality from the group (2).There is no user-visible macro provided for disabling warnings from the group (2). Anyone who wants to silence those warnings should use regular
-Wno-deprecated-declarations.