[SYCL][NFC] Avoid unnecessary calls to event-related functions #20163
Conversation
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Due to an inefficiency in how the event-related functions are called, there is overhead even if the events vector is empty. This is a temporary fix, to avoid the call if not needed.
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| // TODO checking the size of the events vector and avoiding the call is more | ||
| // efficient here at this point |
There was a problem hiding this comment.
It looks like these extra checks only avoid a function call, since the functions themselves already return early if the vector is empty, the benefit here seems minimal (just call-overhead savings). So I am not sure if you mean something additional by inefficiency of those calls?
Considering that, are you sure this TODO comments are actually needed? It feels like these TODOs might never be realistically addressed unless you have some ideas how to do it. If so, probably they should be just removed.
There was a problem hiding this comment.
We generally have way too many function calls to do anything in the runtime. Eliminating unnecessary ones seems like a good goal. Calls into UR especially are not inlined due to the dispatching into plugins and all that, so avoiding unnecessary calls into UR definitely seems like a win.
3 participants
Due to an inefficiency in how the event-related functions are called, there is overhead even if the events vector is empty. This is a temporary fix, to avoid the call if not needed.