[SYCL][Native CPU][NFC] Increase safety. #20173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvdijk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
This should be rebased after #19961 is merged to ensure that meaningful Native CPU testing is run on this PR. |
coldav
approved these changes
Sep 23, 2025
hvdijk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hvdijk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Since we rely on LoopMasks[...] not creating new map entries, since they should have been created in advance, use LoopMasks.at(...) instead. This will ensure that if new changes are introduced that result in any loop masks being missing, it will fail reliably and be much easier to debug. This commit fixes one issue with BOSCC, but this is still NFC as at the moment, BOSCC is never used.
hvdijk
force-pushed
the
vecz-increase-safety
branch
from
a24c426 to
52a96b6
Compare
hvdijk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hvdijk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hvdijk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers This can be merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we rely on LoopMasks[...] not creating new map entries, since they should have been created in advance, use LoopMasks.at(...) instead. This will ensure that if new changes are introduced that result in any loop masks being missing, it will fail reliably and be much easier to debug.
This commit fixes one issue with BOSCC, but this is still NFC as at the moment, BOSCC is never used.