[NFC][SYCL] Drop bfloat16::Bfloat16StorageT
#20180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not part of the specification and should have never been a public type alias inside `bfloat16`. There aren't too many uses of it (`bfloat16` itself and `convertToOpenCLType`/`vec::convert`) so I don't see much value in creating a named type alias.
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YuriPlyakhin
approved these changes
Sep 23, 2025
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
commented
Sep 23, 2025
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
approved these changes
Sep 24, 2025
| using Bfloat16StorageT | ||
| __SYCL_DEPRECATED("bfloat16::Bfloat16StorageT is non-standard and has " | ||
| "been deprecated.") = uint16_t; | ||
| #endif |
There was a problem hiding this comment.
We run the risk of removing this as part of the upcoming ABI-break window. Maybe we should have a comment to prevent that from happening? Otherwise there's probably not much point in deprecating it.
There was a problem hiding this comment.
I say take the risk of breaking someone, because it is unlikely that anyone uses it
There was a problem hiding this comment.
I'm doing it mostly for the trunk users, but I do plan to remove it asap (next major release).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not part of the specification and should have never been a public type alias inside
bfloat16. There aren't too many uses of it (bfloat16itself andconvertToOpenCLType/vec::convert) so I don't see much value in creating a named type alias.