[SYCL] Reduce branching in parallel_for_lambda_impl
#20198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SYCL 2020 is the oldest standard we support, so check `SYCL >= 2020` is always true, dropped the corresponding check; - Outlined calls repeated for both rounded and non-rounded paths into a common section; - Outlined `(void)` casts into a common section to reduce size of `#ifdef` branches for improved readability;
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Do we really need to call it always? |
| typename PropertiesT = ext::oneapi::experimental::empty_properties_t> | ||
| void parallel_for_lambda_impl(range<Dims> UserRange, PropertiesT Props, | ||
| const KernelType &KernelFunc) { | ||
| (void)Props; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYCL >= 2020is always true, dropped the corresponding check;(void)casts into a common section to reduce size of#ifdefbranches for improved readability;Strictly speaking, the patch has a functional side effect: call to
processPropertiesis now hit always, but previously it could be missed if range rounded kernel is being used