-
Notifications
You must be signed in to change notification settings - Fork 791
[SYCL] Add scheduler-bypass for handler-less kernel submission path #20234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Add scheduler-bypass for handler-less kernel submission path #20234
Conversation
The handler-less kernel submission path has been extended to support the fast, scheduler-bypass submission.
@slawekptak In your first PR #19294 the main goal was to introduce interfaces with some minimal implementation. This PR is only about implementation. Should we start unifying the handler and no-handler implementations? |
Sure - my plan is to introduce a series of new PRs right after this one, where the no-handler APIs are extended. This one seemed urgent to me, since we can start optimizing the HostKernel allocation, and we can run the performance benchmarks. |
To test no-handler path in perf CI we must enable it by default (I mean, remove the Also, I did not understand which new APIs you meant. The I suggest focusing on the implementation and removing the |
and call it from the handler and handler-less functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Just had a few NITs
@intel/llvm-gatekeepers please consider merging |
to reflect the new logic behind HostKernel construction.
@intel/llvm-gatekeepers please consider merging |
The handler-less kernel submission path has been extended to support the fast, scheduler-bypass submission.