-
Notifications
You must be signed in to change notification settings - Fork 790
[SYCL] Reintroduce barrier trivial event for empty in-order queue #20263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
steffenlarsen
merged 3 commits into
intel:sycl
from
steffenlarsen:steffen/empty_queue_barrier
Oct 2, 2025
Merged
[SYCL] Reintroduce barrier trivial event for empty in-order queue #20263
steffenlarsen
merged 3 commits into
intel:sycl
from
steffenlarsen:steffen/empty_queue_barrier
Oct 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in intel#20159 removed a test case checking that barriers on empty queues would be considered complete immediately. This commit reintroduces it with a fix for the case. Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
cperkinsintel
approved these changes
Oct 1, 2025
|
@intel/llvm-gatekeepers please consider merging |
uditagarwal97
requested changes
Oct 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holding this patch for the time being, I'm doing perf. evaluation of it.
uditagarwal97
approved these changes
Oct 2, 2025
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Oct 13, 2025
…tel#20263) The changes in intel#20159 removed a test case checking that barriers on empty queues would be considered complete immediately. This commit reintroduces it with a fix for the case. --------- Signed-off-by: Larsen, Steffen <[email protected]>
AlexeySachkov
added a commit
that referenced
this pull request
Oct 16, 2025
…0353) This is a cherry-pick of #20263 The changes in #20159 removed a test case checking that barriers on empty queues would be considered complete immediately. This commit reintroduces it with a fix for the case. Patch-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #20159 removed a test case checking that barriers on empty queues would be considered complete immediately. This commit reintroduces it with a fix for the case.