[SYCL][ESIMD] Decorate dump methods according to LLVM guideline. #20269
Conversation
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
There was a problem hiding this comment.
I see title is saying Decorate dump methods according to LLVM guideline, but in the code I see that in addition to that, it seems dumping of entry points was removed from ESIMD Post split processing. Is it by intention? Could you please provide more details in PR description maybe?
maksimsab
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Some context: this change fixes urgent issue with coverage build which is being built with |
| Linked.rebuildEntryPoints(Names); | ||
| Result.clear(); | ||
| Result.emplace_back(std::move(Linked)); | ||
| DUMP_ENTRY_POINTS(Result.back().entries(), Result.back().Name.c_str(), 4); |
There was a problem hiding this comment.
Just double checking that we don't need this anymore, not even under the appropriate ifdefs?
There was a problem hiding this comment.
We could use LLVM_DEBUG(...) for that. I just don't know whether anyone really needs that.
There was a problem hiding this comment.
I'm good with removing it, just wanted to make sure it was intended.
|
@intel/llvm-gatekeepers please consider merging |
LLVM uses
if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)for decoration of dumping methods. Dumping is used for debugging but not for testing. Therefore, its usage is removed.