Skip to content

[SYCL][UR] Add dynamic linking and program flags #20272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: sycl
Choose a base branch
from
Open

[SYCL][UR] Add dynamic linking and program flags #20272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4100cec
[UR] Add dynamic linking and program flags
steffenlarsen Oct 2, 2025
4e572c6
Address comments
steffenlarsen Oct 3, 2025
1018856
Merge remote-tracking branch 'intel/sycl' into steffen/ur_dyn_link
steffenlarsen Oct 3, 2025
3067c6f
Adjust calls in SYCL runtime
steffenlarsen Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sycl/source/backend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ make_kernel_bundle(ur_native_handle_t NativeHandle,
case (UR_PROGRAM_BINARY_TYPE_NONE):
if (State == bundle_state::object) {
auto Res = Adapter.call_nocheck<UrApiKind::urProgramCompileExp>(
UrProgram, 1u, &Dev, nullptr);
UrProgram, 1u, &Dev, ur_exp_program_flags_t{}, nullptr);
if (Res == UR_RESULT_ERROR_UNSUPPORTED_FEATURE) {
Res = Adapter.call_nocheck<UrApiKind::urProgramCompile>(
ContextImpl.getHandleRef(), UrProgram, nullptr);
Expand All @@ -241,7 +241,7 @@ make_kernel_bundle(ur_native_handle_t NativeHandle,

else if (State == bundle_state::executable) {
auto Res = Adapter.call_nocheck<UrApiKind::urProgramBuildExp>(
UrProgram, 1u, &Dev, nullptr);
UrProgram, 1u, &Dev, ur_exp_program_flags_t{}, nullptr);
if (Res == UR_RESULT_ERROR_UNSUPPORTED_FEATURE) {
Res = Adapter.call_nocheck<UrApiKind::urProgramBuild>(
ContextImpl.getHandleRef(), UrProgram, nullptr);
Expand All @@ -261,8 +261,8 @@ make_kernel_bundle(ur_native_handle_t NativeHandle,
Managed<ur_program_handle_t> UrLinkedProgram{Adapter};
ur_program_handle_t ProgramsToLink[] = {UrProgram};
auto Res = Adapter.call_nocheck<UrApiKind::urProgramLinkExp>(
ContextImpl.getHandleRef(), 1u, &Dev, 1u, ProgramsToLink, nullptr,
&UrLinkedProgram);
ContextImpl.getHandleRef(), 1u, &Dev, ur_exp_program_flags_t{}, 1u,
ProgramsToLink, nullptr, &UrLinkedProgram);
if (Res == UR_RESULT_ERROR_UNSUPPORTED_FEATURE) {
Res = Adapter.call_nocheck<UrApiKind::urProgramLink>(
ContextImpl.getHandleRef(), 1u, ProgramsToLink, nullptr,
Expand Down
3 changes: 2 additions & 1 deletion sycl/source/detail/device_image_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,8 @@ class device_image_impl

std::string XsFlags = extractXsFlags(BuildOptions, MRTCBinInfo->MLanguage);
auto Res = Adapter.call_nocheck<UrApiKind::urProgramBuildExp>(
UrProgram, DeviceVec.size(), DeviceVec.data(), XsFlags.c_str());
UrProgram, DeviceVec.size(), DeviceVec.data(), ur_exp_program_flags_t{},
XsFlags.c_str());
if (Res == UR_RESULT_ERROR_UNSUPPORTED_FEATURE) {
Res = Adapter.call_nocheck<UrApiKind::urProgramBuild>(
ContextImpl.getHandleRef(), UrProgram, XsFlags.c_str());
Expand Down
13 changes: 7 additions & 6 deletions sycl/source/detail/program_manager/program_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1302,7 +1302,7 @@ static ur_result_t doCompile(adapter_impl &Adapter, ur_program_handle_t Program,
// Try to compile with given devices, fall back to compiling with the program
// context if unsupported by the adapter
auto Result = Adapter.call_nocheck<UrApiKind::urProgramCompileExp>(
Program, NumDevs, Devs, Opts);
Program, NumDevs, Devs, ur_exp_program_flags_t{}, Opts);
if (Result == UR_RESULT_ERROR_UNSUPPORTED_FEATURE) {
return Adapter.call_nocheck<UrApiKind::urProgramCompile>(Ctx, Program,
Opts);
Expand Down Expand Up @@ -1723,7 +1723,8 @@ Managed<ur_program_handle_t> ProgramManager::build(
? CompileOptions
: (CompileOptions + " " + LinkOptions);
ur_result_t Error = Adapter.call_nocheck<UrApiKind::urProgramBuildExp>(
Program, Devices.size(), Devices.data(), Options.c_str());
Program, Devices.size(), Devices.data(), ur_exp_program_flags_t{},
Options.c_str());
if (Error == UR_RESULT_ERROR_UNSUPPORTED_FEATURE) {
Error = Adapter.call_nocheck<UrApiKind::urProgramBuild>(
Context.getHandleRef(), Program, Options.c_str());
Expand Down Expand Up @@ -1759,8 +1760,8 @@ Managed<ur_program_handle_t> ProgramManager::build(
auto doLink = [&] {
auto Res = Adapter.call_nocheck<UrApiKind::urProgramLinkExp>(
Context.getHandleRef(), Devices.size(), Devices.data(),
LinkPrograms.size(), LinkPrograms.data(), LinkOptions.c_str(),
&LinkedProg);
ur_exp_program_flags_t{}, LinkPrograms.size(), LinkPrograms.data(),
LinkOptions.c_str(), &LinkedProg);
if (Res == UR_RESULT_ERROR_UNSUPPORTED_FEATURE) {
Res = Adapter.call_nocheck<UrApiKind::urProgramLink>(
Context.getHandleRef(), LinkPrograms.size(), LinkPrograms.data(),
Expand Down Expand Up @@ -3001,8 +3002,8 @@ ProgramManager::link(const std::vector<device_image_plain> &Imgs,
auto doLink = [&] {
auto Res = Adapter.call_nocheck<UrApiKind::urProgramLinkExp>(
ContextImpl.getHandleRef(), URDevices.size(), URDevices.data(),
URPrograms.size(), URPrograms.data(), LinkOptionsStr.c_str(),
&LinkedProg);
ur_exp_program_flags_t{}, URPrograms.size(), URPrograms.data(),
LinkOptionsStr.c_str(), &LinkedProg);
if (Res == UR_RESULT_ERROR_UNSUPPORTED_FEATURE) {
Res = Adapter.call_nocheck<UrApiKind::urProgramLink>(
ContextImpl.getHandleRef(), URPrograms.size(), URPrograms.data(),
Expand Down
86 changes: 86 additions & 0 deletions unified-runtime/include/ur_api.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions unified-runtime/include/ur_api_funcs.def
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 12 additions & 6 deletions unified-runtime/include/ur_ddi.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions unified-runtime/include/ur_print.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading