Skip to content

[CI] Fail benchmark CI only on regressions in CPU instruction count #20277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from
+6 −2
Open

[CI] Fail benchmark CI only on regressions in CPU instruction count #20277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cf6c45
change filter to include only CPU cycles
ianayl Oct 2, 2025
b2fa113
leave comment to prevent rug pulls
ianayl Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions devops/actions/run-tests/benchmark/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,8 @@ runs:
--name "$SAVE_NAME" \
--compare-file "./llvm-ci-perf-results/results/${SAVE_NAME}_${SAVE_TIMESTAMP}.json" \
--results-dir "./llvm-ci-perf-results/results/" \
--regression-filter '^[a-z_]+_sycl ' \
--regression-filter-type 'SYCL' \
--regression-filter '^[a-z_]+_sycl .* CPU count' \
--regression-filter-type 'SYCL benchmark (measured using CPU cycle count)' \
--verbose \
--produce-github-summary \
${{ inputs.dry_run == 'true' && '--dry-run' || '' }} \
Expand Down
4 changes: 4 additions & 0 deletions devops/scripts/benchmarks/benches/compute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,10 @@ def run(
ret = []
for label, median, stddev, unit in parsed_results:
extra_label = " CPU count" if parse_unit_type(unit) == "instr" else ""
# Note: SYCL CI currently parses for on this "CPU count" value.
# Please update /devops/scripts/benchmarks/compare.py if this value
# is changed. See compare.py usage (w.r.t. --regression-filter) in
# /devops/actions/run-tests/benchmarks/action.yml.
ret.append(
Result(
label=self.name() + extra_label,
Expand Down
Loading