Skip to content

[SYCL][Graph][UR] Elide second barrier in finalizeCommandBuffer when possible #20278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from
+7 −2
Open

[SYCL][Graph][UR] Elide second barrier in finalizeCommandBuffer when possible #20278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a6390f
[SYCL][Graph][UR] Elide second barrier in graph finalize if possible
adamfidel Oct 6, 2025
a884f3a
fix formatting
reble Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions unified-runtime/source/adapters/level_zero/v2/command_buffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,19 +131,24 @@ ur_result_t ur_exp_command_buffer_handle_t_::finalizeCommandBuffer() {
auto commandListLocked = commandListManager.lock();
UR_ASSERT(!isFinalized, UR_RESULT_ERROR_INVALID_OPERATION);

size_t numEventResets = 0;

if (!isInOrder) {
ZE2UR_CALL(zeCommandListAppendBarrier,
(commandListLocked->getZeCommandList(), nullptr, 0, nullptr));
for (size_t i = 0; i < usedSyncPoints.size(); ++i) {
if (!usedSyncPoints[i]) {
continue;
}
++numEventResets;
ZE2UR_CALL(
zeCommandListAppendEventReset,
(commandListLocked->getZeCommandList(), syncPoints[i]->getZeEvent()));
}
ZE2UR_CALL(zeCommandListAppendBarrier,
(commandListLocked->getZeCommandList(), nullptr, 0, nullptr));

if (numEventResets)
ZE2UR_CALL(zeCommandListAppendBarrier,
(commandListLocked->getZeCommandList(), nullptr, 0, nullptr));
}
// Close the command lists and have them ready for dispatch.
ZE2UR_CALL(zeCommandListClose, (commandListLocked->getZeCommandList()));
Expand Down