Skip to content

[UR][L0v2] Disable by default on integrated devices #20281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from
Open

[UR][L0v2] Disable by default on integrated devices #20281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbdbe1f
[UR][L0v2] Disable by default on integrated devices
kswiecicki Oct 6, 2025
9a3b579
[SYCL][UR][L0v2] Mark interop-get-native-mem.cpp unsupported
kswiecicki Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sycl/test-e2e/Adapters/level_zero/interop-get-native-mem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
// RUN: %{build} %level_zero_options -o %t.out
// RUN: %{run} %t.out

// L0v2 adapter does not support integrated buffers yet
// UNSUPPORTED: level_zero_v2_adapter
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/20280

// Test get_native_mem for the Level Zero backend.

// Level-Zero
Expand Down
39 changes: 25 additions & 14 deletions unified-runtime/source/adapters/level_zero/adapter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ ur_result_t getZesDeviceHandle(ur_adapter_handle_t_ *adapter,
return UR_RESULT_ERROR_INVALID_ARGUMENT;
}

ur_result_t checkDeviceIntelGPUIpVersionOrNewer(uint32_t ipVersion) {
ur_result_t checkDeviceAnyIntelGPUPropertyMatch(
std::function<bool(ze_device_properties_t &)> predicate) {
uint32_t ZeDriverCount = 0;
ZE2UR_CALL(zeDriverGet, (&ZeDriverCount, nullptr));
if (ZeDriverCount == 0) {
Expand All @@ -106,12 +107,9 @@ ur_result_t checkDeviceIntelGPUIpVersionOrNewer(uint32_t ipVersion) {
for (uint32_t D = 0; D < ZeDeviceCount; ++D) {
ZE2UR_CALL(zeDeviceGetProperties, (ZeDevices[D], &device_properties));
if (device_properties.type == ZE_DEVICE_TYPE_GPU &&
device_properties.vendorId == 0x8086) {
ze_device_ip_version_ext_t *ipVersionExt =
(ze_device_ip_version_ext_t *)device_properties.pNext;
if (ipVersionExt->ipVersion >= ipVersion) {
return UR_RESULT_SUCCESS;
}
device_properties.vendorId == 0x8086 &&
predicate(device_properties)) {
return UR_RESULT_SUCCESS;
}
}
}
Expand Down Expand Up @@ -261,11 +259,25 @@ ur_result_t adapterStateInit() {
return UR_RESULT_SUCCESS;
}

static bool isBMGorNewer() {
auto urResult = checkDeviceIntelGPUIpVersionOrNewer(0x05004000);
static bool isBMGorNewer(bool excludeIntegrated = false) {
auto checkBMGorNewer =
[&excludeIntegrated](ze_device_properties_t &device_properties) {
ze_device_ip_version_ext_t *ipVersionExt =
(ze_device_ip_version_ext_t *)device_properties.pNext;

bool isIntegrated =
device_properties.flags & ZE_DEVICE_PROPERTY_FLAG_INTEGRATED;
if (excludeIntegrated && isIntegrated) {
return false;
}

return ipVersionExt->ipVersion >= 0x05004000;
};

auto urResult = checkDeviceAnyIntelGPUPropertyMatch(checkBMGorNewer);
if (urResult != UR_RESULT_SUCCESS &&
urResult != UR_RESULT_ERROR_UNSUPPORTED_VERSION) {
UR_LOG(ERR, "Intel GPU IP Version check failed: {}\n", urResult);
UR_LOG(ERR, "Intel GPU device property check failed: {}\n", urResult);
throw urResult;
}

Expand Down Expand Up @@ -297,8 +309,8 @@ static std::pair<bool, std::string> shouldUseV1Adapter() {
return {true, reason};
}

// default: only enable for devices older than BMG
return {!isBMGorNewer(), reason};
// default: enable for devices older than BMG and integrated devices
return {!isBMGorNewer(/* excludeIntegrated */ true), reason};
}

[[maybe_unused]] static std::pair<bool, std::string> shouldUseV2Adapter() {
Expand Down Expand Up @@ -532,8 +544,7 @@ ur_adapter_handle_t_::ur_adapter_handle_t_()
bool ZesInitNeeded = UrSysmanZesinitEnable && !UrSysManEnvInitEnabled;
// Unless the user has forced the SysMan init, we will check the device
// version to see if the zesInit is needed.
if (UserForcedSysManInit == 0 &&
checkDeviceIntelGPUIpVersionOrNewer(0x05004000) == UR_RESULT_SUCCESS) {
if (UserForcedSysManInit == 0 && isBMGorNewer()) {
if (UrSysManEnvInitEnabled) {
setEnvVar("ZES_ENABLE_SYSMAN", "0");
}
Expand Down
Loading