Skip to content

[scripts] Persist ur_function_t max ID in registry generation #20284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
+12 −2
Open

[scripts] Persist ur_function_t max ID in registry generation #20284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions unified-runtime/scripts/core/registry.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,7 @@ etors:
- name: BINDLESS_IMAGES_SUPPORTS_IMPORTING_HANDLE_TYPE_EXP
desc: Enumerator for $xBindlessImagesSupportsImportingHandleTypeExp
value: '288'
max_id: '288'
---
type: enum
desc: Defines structure types
Expand Down
13 changes: 11 additions & 2 deletions unified-runtime/scripts/generate_ids.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,14 @@ def generate_function_type(
etor["name"]: etor["value"] for etor in existing_function_type["etors"]
}
max_etor = get_max_enum(existing_function_type)
stored_max_etor = existing_function_type.get("max_id")
try:
stored_max_etor = int(stored_max_etor) if stored_max_etor is not None else None
except ValueError:
stored_max_etor = None
persistent_max = (
max_etor if stored_max_etor is None else max(max_etor, stored_max_etor)
)
functions = [
obj for s in specs for obj in s["objects"] if obj["type"] == "function"
]
Expand All @@ -73,8 +81,8 @@ def generate_function_type(
etor_name = "$X_FUNCTION_" + util.to_snake_case(fname).upper()
id = existing_etors.get(etor_name)
if id is None:
max_etor += 1
id = max_etor
persistent_max += 1
id = persistent_max
entry = {
"name": etor_name,
"desc": f"Enumerator for $x{fname}",
Expand All @@ -85,6 +93,7 @@ def generate_function_type(
registry.append(entry)
registry = sorted(registry, key=lambda x: int(x["value"]))
existing_function_type["etors"] = registry
existing_function_type["max_id"] = str(persistent_max)
update_fn(existing_function_type, meta)

## create a copy to write back to registry.yml
Expand Down