Skip to content

[SYCL] "No last event mode" support for handler-less kernel submission #20313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2025
Merged

[SYCL] "No last event mode" support for handler-less kernel submission #20313

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0349712
[SYCL] "No last event mode" support for handler-less kernel submission
slawekptak Oct 8, 2025
fb4fc7d
Add the in order queue condition
slawekptak Oct 8, 2025
83f42ee
Refactor the MNoLastEventMode var set
slawekptak Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions sycl/source/detail/queue_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,10 +621,6 @@ queue_impl::submit_direct(bool CallerNeedsEvent,
detail::CG::StorageInitHelper CGData;
std::unique_lock<std::mutex> Lock(MMutex);

// Set the No Last Event Mode to false, since the no-handler path
// does not support it yet.
MNoLastEventMode.store(false, std::memory_order_relaxed);

// Used by queue_empty() and getLastEvent()
MEmpty.store(false, std::memory_order_release);

Expand Down Expand Up @@ -662,6 +658,14 @@ queue_impl::submit_direct(bool CallerNeedsEvent,
: true) &&
!hasCommandGraph();

// Synchronize with the "no last event mode", used by the handler-based
// kernel submit path
if (SchedulerBypass) {
MNoLastEventMode.store(true, std::memory_order_relaxed);
} else {
MNoLastEventMode.store(false, std::memory_order_relaxed);
}

EventImplPtr EventImpl = SubmitCommandFunc(CGData, SchedulerBypass);

// Sync with the last event for in order queue. For scheduler-bypass flow,
Expand Down