Skip to content

Check if xptiTraceEnabled only once on the hot paths #20320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 8, 2025
Merged

Check if xptiTraceEnabled only once on the hot paths #20320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf55536
Check if xptiTraceEnabled only once on the hot paths
vinser52 Oct 8, 2025
0d929d0
Update sycl/source/detail/queue_impl.cpp
vinser52 Oct 8, 2025
b616b3c
Update sycl/source/detail/queue_impl.cpp
vinser52 Oct 8, 2025
d67fe52
Update sycl/source/detail/graph/graph_impl.cpp
vinser52 Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sycl/source/detail/graph/graph_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,8 +742,9 @@ exec_graph_impl::enqueueNodeDirect(const sycl::context &Ctx,
const bool xptiEnabled = xptiTraceEnabled();
xpti_td *CmdTraceEvent = nullptr;
uint64_t InstanceID = 0;
auto StreamID = detail::getActiveXPTIStreamID();
uint8_t StreamID = 0;
if (xptiEnabled) {
StreamID = detail::getActiveXPTIStreamID();
sycl::detail::CGExecKernel *CGExec =
static_cast<sycl::detail::CGExecKernel *>(Node.MCommandGroup.get());
sycl::detail::code_location CodeLoc(CGExec->MFileName.c_str(),
Expand Down
17 changes: 12 additions & 5 deletions sycl/source/detail/queue_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,11 +448,12 @@ EventImplPtr queue_impl::submit_kernel_scheduler_bypass(
#ifdef XPTI_ENABLE_INSTRUMENTATION
xpti_td *CmdTraceEvent = nullptr;
uint64_t InstanceID = 0;
auto StreamID = detail::getActiveXPTIStreamID();
uint8_t StreamID = 0;
// Only enable instrumentation if there are subscribes to the SYCL
// stream
const bool xptiEnabled = xptiCheckTraceEnabled(StreamID);
const bool xptiEnabled = xptiTraceEnabled();
if (xptiEnabled) {
StreamID = detail::getActiveXPTIStreamID();
std::tie(CmdTraceEvent, InstanceID) = emitKernelInstrumentationData(
StreamID, KernelImplPtr, CodeLoc, IsTopCodeLoc,
*KData.getDeviceKernelInfoPtr(), this, KData.getNDRDesc(),
Expand Down Expand Up @@ -843,8 +844,12 @@ void queue_impl::wait(const detail::code_location &CodeLoc) {
void *TelemetryEvent = nullptr;
uint64_t IId;
std::string Name;
auto StreamID = detail::getActiveXPTIStreamID();
TelemetryEvent = instrumentationProlog(CodeLoc, Name, StreamID, IId);
uint8_t StreamID = 0;
const bool xptiEnabled = xptiTraceEnabled();
if (xptiEnabled) {
StreamID = detail::getActiveXPTIStreamID();
TelemetryEvent = instrumentationProlog(CodeLoc, Name, StreamID, IId);
}
#endif

if (!MGraph.expired()) {
Expand Down Expand Up @@ -926,7 +931,9 @@ void queue_impl::wait(const detail::code_location &CodeLoc) {
#ifdef XPTI_ENABLE_INSTRUMENTATION
// There is an early return in instrumentationEpilog() if no subscribers are
// subscribing to queue.wait().
instrumentationEpilog(TelemetryEvent, Name, StreamID, IId);
if (xptiEnabled) {
instrumentationEpilog(TelemetryEvent, Name, StreamID, IId);
}
#endif
}

Expand Down