[SYCL][clang-linker-wrapper] Add -sycl-bc-device-libraries option for linking bitcode device libraries

[jzc]

This PR adds the -sycl-bc-device-libraries option to clang-linker-wrapper properly link bitcode device libraries that are used in NVIDIA and AMD GPU targets in SYCL offloading.

SYCL::getDeviceLibraries() returns both fat objects and bitcode device libraries mixed together, while the -sycl-device-libraries option only handles fat objects. This was causing clang-linker-wrapper to not link the libdevice for nvptx/AMD targets.

This PR also removes the -sycl-nvptx-device-libraries option, which seemed to be doing the same thing but only for nvptx targets.

[bader]

This PR adds the -sycl-bc-device-libraries option to clang-linker-wrapper properly link bitcode device libraries that are used in NVIDIA and AMD GPU targets in SYCL offloading.

SYCL::getDeviceLibraries() returns both fat objects and bitcode device libraries mixed together, while the -sycl-device-libraries option only handles fat objects. This was causing clang-linker-wrapper to not link the libdevice for nvptx/AMD targets.

This PR also removes the -sycl-nvptx-device-libraries option, which seemed to be doing the same thing but only for nvptx targets.

This seems unnecessary. clang-linker-wrapper already supports bitcode-library and builtin-bitcode options which driver can use to pass libdevice.

[jzc]

@bader I did try using these options, but I wasn't able to get them to work, although I'm unsure the reason. Let me try again see what went wrong and see if I can use these options

[bader]

FYI: #20326 removes these options.

[bader]

@bader I did try using these options, but I wasn't able to get them to work, although I'm unsure the reason. Let me try again see what went wrong and see if I can use these options

Please, pay attention to the way the driver builds command line arguments for the clang-linker-wrapper. SYCL specific option accepts a list of library paths separated by coma, whereas existing options accept only one path. To pass multiple libraries the driver must pass multiple arguments: one per library.

[YuriPlyakhin]

I'll review, after comments from Alexey are addressed.