-
Notifications
You must be signed in to change notification settings - Fork 792
[CI] Add precompiled CTS tests to sycl_prebuilt_tests image #20332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
@aelovikov-intel ping for awareness |
Test run at https://github.com/intel/llvm/actions/runs/18386413684 CTS tests are running as expected, but there seems to be a single failure. It doesn't seem to be related to the workflow, but I still need to look into why it is failing. |
Let's also update the description in sycl-prebuilt-e2e-container.yml: llvm/.github/workflows/sycl-prebuilt-e2e-container.yml Lines 3 to 5 in dabf72a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable in general, just a few inline comments.
Co-authored-by: Andrei Elovikov <[email protected]>
default: | ||
cts_ref: | ||
type: choice | ||
description: tag/sha to use for CTS -- hardcoded hash is last known good commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think "good" is appropriate description. I think it's what our sycl-rel-smth
branch is "known" to work with. Maybe @KornevNikita or @AlexeySachkov could suggest better wording here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the word "stable", but is anything ever truly stable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We take the sycl-cts hash closest to the last sycl commit that was added to the sycl-rel-* branch.
I think stable sounds good enough. Or may be some thing like "hardcoded hash is the SYCL-CTS version that successfully passes with the latest release toolchain"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How's "tag/sha to use for SYCL-CTS -- hardcoded hash is last known commit to pass with latest release toolchain"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, "SYCL CTS revision matching sycl-rel-N_M branch"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I currently have "tag/sha to use for SYCL-CTS -- hardcoded hash is CTS revision matching sycl-rel-N_M branch."
This PR adds precompiled CTS binaries to
sycl-prebuilt-e2e-container.yml
.Note that this PR also renames some fields in
devops/actions/run-tests/cts/action.yml
to match that ofrun-tests/e2e/action.yml
. If this is unwanted I will undo the changes.