Fix the MemorySanitizer/check_large_access.cpp test failure #20344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
reviewed
Oct 13, 2025
| } | ||
|
|
||
| // Handle arbitrary number of 32-bit words for integer literals | ||
| if (Opcode == SPIRV::OpConstantI && NumVarOps > 2) { |
There was a problem hiding this comment.
Should these changes go upstream?
There was a problem hiding this comment.
Hello Nick! Yes, these changes will go to the upstream llvm-project (PR link: llvm/llvm-project#161270). This PR was created to test whether the changes would cause any failures in the SYCL tests before submitting upstream. I have added this to the PR description. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for integers larger than 64 bits in the SPIR-V Backend to fix the current failure in the SYCL E2E test MemorySanitizer/check_large_access.cpp. This test was previously failing because 96-bit integers were unsupported in the SPIR-V Backend.
Note: The changes in this PR will not be merged. This PR was created solely to test whether the changes would cause any failures in our SYCL tests before submitting upstream llvm-project.