[l0 v2] Add optional-returning USM pool config parser #20350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KFilipek
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
KFilipek
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KFilipek
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KFilipek
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
pbalcer
reviewed
Oct 13, 2025
Introduces parseDisjointPoolConfigOptional() that returns std::nullopt when pooling is disabled (EnableBuffers == 0), replacing the manual check in the Level Zero v2 adapter. This resolves the TODO to rework parseDisjointPoolConfig.
KFilipek
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
pbalcer
approved these changes
Oct 14, 2025
KFilipek
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KFilipek
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kswiecicki
approved these changes
Oct 14, 2025
|
@intel/llvm-gatekeepers please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 2 commits, first is just simplification of existing code, second is a rework to resolve TODO and provide the std::optional as a return value.