Skip to content

Conversation

vinser52
Copy link
Contributor

Remove lazy initialization for the ur_kernel_handle_t_::zeCommonProperties to avoid TLS access on the hot path.

@vinser52 vinser52 requested a review from a team as a code owner October 13, 2025 12:40
Copy link
Contributor

@bratpiorka bratpiorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbalcer
Copy link
Contributor

pbalcer commented Oct 13, 2025

@vinser52
Copy link
Contributor Author

https://intel.github.io/llvm/benchmarks/?runs=no_tls_setargs_BMG_L0v2%2CBaseline_BMG_L0v2&regex=SubmitKernel.*in+order

Yeah, I also did a benchmark run by myself (I had to put the link earlier): https://intel.github.io/llvm/benchmarks/?runs=Baseline_BMG_L0v2%2CPR20351_BMG_L0v2&regex=in+order

There is a visible improvement in the number of instructions retired.

@vinser52
Copy link
Contributor Author

vinser52 commented Oct 13, 2025

image

For some reason the impact on the SYCL version of the benchmark is higher

@vinser52
Copy link
Contributor Author

@intel/llvm-gatekeepers, PR is ready to be merged.

@sarnex sarnex merged commit 68bc193 into intel:sycl Oct 14, 2025
135 of 148 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants