[SYCL][NFC] Use unique_ptr for storing ModuleDesc. #20358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch resolves a warning about expensive copy in function invocation which accept ModuleDesc by value, thus taking ownership of ModuleDesc. Now ownership is transfered into functions by using unuqie_ptr. Also, the patch removes many usages of r-value references in function's arguments because r-value reference supposes a ownership transfer but does not oblige that.
maksimsab
requested review from
a team,
aelovikov-intel and
cperkinsintel
as code owners
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
approved these changes
Oct 14, 2025
aelovikov-intel
approved these changes
Oct 14, 2025
cperkinsintel
approved these changes
Oct 15, 2025
Tradeoffs in both cases are negligible. The goal of the PR is just to resolve the warning. @intel/llvm-gatekeepers Can we merge that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resolves a warning about expensive copy in function invocation which accepts ModuleDesc by value, thus taking ownership of ModuleDesc. Now ownership is transferred into functions by using unuqie_ptr. Also, the patch removes many usages of r-value references in function's arguments because r-value reference supposes a ownership transfer but does not oblige that.