[CI][Bench] Cleanup in benchmarks jobs and scripts #20369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszstolarczuk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
approved these changes
Oct 15, 2025
lukaszstolarczuk
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
lukaszstolarczuk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
requested changes
Oct 15, 2025
devops/scripts/benchmarks/README.md
Outdated
|
|
||
| To execute the benchmarks in CI, navigate to the `Actions` tab and then go to the `Compute Benchmarks` action. Here, you will find a list of previous runs and a "Run workflow" button. Upon clicking the button, you will be prompted to fill in a form to customize your benchmark run. The only mandatory field is the `PR number`, which is the identifier for the Pull Request against which you want the benchmarks to run. | ||
| To execute the benchmarks in CI, navigate to the `Actions` tab and then go to the `Run Benchmarks` workflow. Here, you will find a list of previous runs and a "Run workflow" button. Upon clicking the button, you will be prompted to fill in a form to customize your benchmark run. Important field is the `PR number`, which is the identifier for the Pull Request against which you want the benchmarks to run. Instead, you can specify `Commit hash` from within intel/llvm repository, or leave both | ||
| empty to run benchmarks against the latest commit from default branch. |
There was a problem hiding this comment.
I think that the latest commit from the branch you pick up as the first drop-down list is taken in this case, but please verify that.
There was a problem hiding this comment.
Let me double check this, but IIRC that dropdown list version is: Pretty sure this is the case:
- used if PR/commit hash is not provided
- if PR/commit hash is provided, the dropdown list version only affects the version of benchmark workflow/suite used, the build still relies on PR/commit hash field
|
File delete LGTM, I totally forgot about the aggregate workflow. Thanks for doing the clean up! |
lukaszstolarczuk
force-pushed
the
benchmarks-scripts
branch
from
7baf697 to
2ce7e21
Compare
lukaszstolarczuk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lukaszstolarczuk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lukaszstolarczuk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
approved these changes
Oct 16, 2025
|
@intel/llvm-gatekeepers , can you please merge? |
|
Unexpectedly Passed Tests (1): Reported in #20142. Looks to be flaky, so it should be made UNSUPPORTED. |
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
Oct 16, 2025
As observed in intel#20369, the Regression/barrier_with_work.cpp E2E test may pass sporadically. As such it should be made UNSUPPORTED instead of XFAIL. Signed-off-by: Larsen, Steffen <[email protected]>
againull
pushed a commit
that referenced
this pull request
Oct 17, 2025
As observed in #20369, the Regression/barrier_with_work.cpp E2E test may pass sporadically. As such it should be made UNSUPPORTED instead of XFAIL. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sycl-benchmark-aggregate.ymlseems like a dead codecodespell