Skip to content

Conversation

maarquitos14
Copy link
Contributor

Last pulldown pulled the deprecation of %T for llvm-lit, and DeviceImageDependencies tests were using it. It was reported that %t.dir wasn't working for these tests in the pulldown PR (#20343 (comment)), and a workaround was made to make them pass provisionally. This patch moves to %t.dir as it's the standard way after %T removal.

@maarquitos14 maarquitos14 requested a review from a team as a code owner October 15, 2025 18:52
@bader
Copy link
Contributor

bader commented Oct 15, 2025

@maarquitos14, what about this comment: #20343 (comment)?

@maarquitos14
Copy link
Contributor Author

@maarquitos14, what about this comment: #20343 (comment)?

My understanding of that comment is that @aelovikov-intel asked to remove those two commands while we were using the workaround, but now that you bring it up I'm not so sure. Please, @aelovikov-intel, can you confirm?

Actually, I think what's missing is the rm command, but let's wait for Andrei's confirmation.

@aelovikov-intel
Copy link
Contributor

%t.dir should come with rm -rf %t.dir ; mkdir -p %t.dir. We couldn't do the rm part when using %t/.. because that would have affected other tests, but now we should add the rm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants