Skip to content

Conversation

lslusarczyk
Copy link
Contributor

Add filename and line numer to log statements in benchmark dashboard log.
Removed not needed code from benchmark logging.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds filename and line number information to log statements in the benchmark dashboard and refactors the logging implementation. The changes simplify the logging architecture by removing the singleton BenchmarkLogger class and replacing it with a simpler module-level approach.

  • Replaced singleton BenchmarkLogger class with a simpler module-level logger and initialization function
  • Updated log formatter to include filename and line number information (<filename:line>)
  • Updated import statements and function calls across files to use the new logging interface

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
devops/scripts/benchmarks/utils/logger.py Complete refactor from singleton class to module-level logger with enhanced formatting
devops/scripts/benchmarks/main.py Updated import and function call to use new logging interface
devops/scripts/benchmarks/compare.py Updated import and function call to use new logging interface

Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@sarnex sarnex merged commit 1f89d58 into intel:sycl Oct 16, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants