[SYCL RTC] Make ToolchainFS static thread_local
#20382
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intel#19924 essentially made it `static` but that caused data races that were later fixed by intel#20360 changing each use of it to re-create this in-memory FS (essentially, "removing" `static`), incurring significant performance costs. This PR addresses the issue by "adding" `thread_local` instead of "removing" `static` allowing us to have both no crashes due to data races and minimal overhead. No tests added as the one from intel#20360 is verifying this.
aelovikov-intel
requested review from
a team and
cperkinsintel
as code owners
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19924 essentially made it
staticbut that caused data races that were later fixed by #20360 changing each use of it to re-create this in-memory FS (essentially, "removing"static), incurring significant performance costs.This PR addresses the issue by "adding"
thread_localinstead of "removing"staticallowing us to have both no crashes due to data races and minimal overhead.No tests added as the one from #20360 is verifying this.