Skip to content

[Benchmarks] Pin benchmarks to small set of cores #20403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: sycl
Choose a base branch
from
Open

[Benchmarks] Pin benchmarks to small set of cores #20403

wants to merge 7 commits into from
+41 −25

Conversation

@PatKamin
Copy link
Contributor

For better results stability, pin benchmark binaries to four cores with the maximum available frequency.

@PatKamin PatKamin requested review from a team as code owners October 20, 2025 17:39
@PatKamin PatKamin force-pushed the pin-4-cores-for-benches branch from 10804b3 to 8855934 Compare October 20, 2025 18:54
@PatKamin
Copy link
Contributor Author

Test run on the PVC perf machine: https://github.com/intel/llvm/actions/runs/18679758239/job/53258464661

lukaszstolarczuk
lukaszstolarczuk reviewed Oct 21, 2025
View reviewed changes
@PatKamin PatKamin requested review from a team and vinser52 October 21, 2025 12:06
@PatKamin
[Benchmarks] Pin benchmarks to small set of cores
21fa7fb 
For better results stability, pin benchmark binaries to four cores with the maximum available frequency.
lslusarczyk
lslusarczyk reviewed Oct 22, 2025
View reviewed changes
Copy link
Contributor

@lslusarczyk lslusarczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions

@PatKamin PatKamin force-pushed the pin-4-cores-for-benches branch from 8855934 to e5b651a Compare October 22, 2025 10:08
lslusarczyk
lslusarczyk reviewed Oct 22, 2025
View reviewed changes
lukaszstolarczuk
lukaszstolarczuk reviewed Oct 22, 2025
View reviewed changes
@PatKamin PatKamin force-pushed the pin-4-cores-for-benches branch from e5b651a to 670adfc Compare October 22, 2025 14:50
pbalcer
pbalcer reviewed Oct 23, 2025
View reviewed changes
lslusarczyk
lslusarczyk reviewed Oct 23, 2025
View reviewed changes
@PatKamin PatKamin requested a review from lslusarczyk October 24, 2025 08:14
lslusarczyk
lslusarczyk reviewed Oct 24, 2025
View reviewed changes
@PatKamin @lslusarczyk
taskset_cmd refactor
a0aacd5 
Co-authored-by: Łukasz Ślusarczyk <[email protected]>
@PatKamin
Copy link
Contributor Author

PatKamin commented Oct 29, 2025 •
edited
Loading

@intel/dpcpp-devops-reviewers, please review. This change is required for the new perf setup in CI.

pbalcer
pbalcer reviewed Oct 29, 2025
View reviewed changes
lukaszstolarczuk
lukaszstolarczuk approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PatKamin
Copy link
Contributor Author

@intel/dpcpp-devops-reviewers, is adding numactl package to docker images ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinser52 vinser52 vinser52 approved these changes

@pbalcer pbalcer pbalcer approved these changes

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

@lslusarczyk lslusarczyk lslusarczyk approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PatKamin @vinser52 @pbalcer @lukaszstolarczuk @lslusarczyk