Skip to content

[CI][Benchmarks] do not build and run E2E test on benchmark only changes #20414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: sycl
Choose a base branch
from
+29 −6
Draft

[CI][Benchmarks] do not build and run E2E test on benchmark only changes #20414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b210eba
Small change to test benchmarks change
lslusarczyk Oct 21, 2025
6354502
do not build and run E2E test on benchmark only changes
lslusarczyk Oct 21, 2025
554c72e
check
lslusarczyk Oct 21, 2025
0980768
Revert "Small change to test benchmarks change"
lslusarczyk Oct 22, 2025
840b448
add juju
lslusarczyk Oct 22, 2025
bb7c062
less e2e tests
lslusarczyk Oct 22, 2025
ce8a9a4
Reapply "Small change to test benchmarks change"
lslusarczyk Oct 22, 2025
02fe964
fix
lslusarczyk Oct 22, 2025
1a07410
Revert "Reapply "Small change to test benchmarks change""
lslusarczyk Oct 22, 2025
e0304a2
revert debug changes
lslusarczyk Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .github/workflows/sycl-detect-changes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
filters:
description: Matched filters
value: ${{ jobs.need_check.outputs.filters }}
benchmarks_only:
description: Whether only benchmarks were changed
value: ${{ jobs.need_check.outputs.benchmarks_only }}

permissions: read-all

Expand All @@ -16,6 +19,7 @@ jobs:
timeout-minutes: 3
outputs:
filters: ${{ steps.result.outputs.result }}
benchmarks_only: ${{ steps.benchmarks_only.outputs.result }}
steps:
- name: Set changed_files
id: changed_files
Expand Down Expand Up @@ -103,5 +107,17 @@ jobs:
// Treat everything as changed for huge PRs.
return ["llvm", "llvm_spirv", "clang", "sycl_jit", "xptifw", "libclc", "sycl", "ci", "esimd", "ur", "ur_cuda_adapter", "ur_offload_adapter"];

- run: echo '${{ steps.result.outputs.result }}'

- name: Set benchmarks_only output
id: benchmarks_only
env:
CHANGES: ${{ steps.changes.outputs.changes }}
run: |
has_benchmarks_only=true
for change in $(echo "$CHANGES" | tr -d '[]" ' | tr ',' '\n'); do
if [[ "$change" != "benchmarks" ]]; then
has_benchmarks_only=false
fi
done
echo "result=$has_benchmarks_only" >> $GITHUB_OUTPUT

- run: echo '${{ steps.result.outputs.result }} ${{ steps.benchmarks_only.outputs.result }}'
14 changes: 10 additions & 4 deletions .github/workflows/sycl-linux-precommit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,16 @@ jobs:
changes: ${{ needs.detect_changes.outputs.filters }}

toolchain_artifact: sycl_linux_default
e2e_binaries_artifact: e2e_bin
e2e_binaries_preview_artifact: e2e_bin_preview
e2e_binaries_artifact: ${{ needs.detect_changes.outputs.benchmarks_only != 'true' && 'e2e_bin' || '' }}
e2e_binaries_preview_artifact: ${{ needs.detect_changes.outputs.benchmarks_only != 'true' && 'e2e_bin_preview' || '' }}

# Build and run native cpu e2e tests separately as cannot currently
# build all the e2e tests
build_run_native_cpu_e2e_tests:
if: ${{ always() && !cancelled() && needs.build.outputs.build_conclusion == 'success' }}
if: |
always() && !cancelled()
&& needs.build.outputs.build_conclusion == 'success'
&& needs.detect_changes.outputs.benchmarks_only == 'false'
runs-on: [Linux, build]
needs: [build]
container:
Expand Down Expand Up @@ -138,7 +141,10 @@ jobs:

E2E:
needs: [build, detect_changes, compat_read_exclude]
if: ${{ always() && !cancelled() && needs.build.outputs.build_conclusion == 'success' }}
if: |
always() && !cancelled()
&& needs.build.outputs.build_conclusion == 'success'
&& needs.detect_changes.outputs.benchmarks_only == 'false'
strategy:
fail-fast: false
matrix:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/sycl-windows-precommit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ on:
- 'devops/containers/**'
- 'devops/actions/build_container/**'
- 'devops/compat_ci_exclude.sycl-rel-6_2'
- 'devops/scripts/benchmarks/**'
- 'unified-runtime/examples/**'
- 'unified-runtime/scripts/**'
- 'unified-runtime/test/**'
Expand Down
Loading