[SYCL] Fix coverity hits in queue & graph #20617
Open
+23
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| bool graph_impl::clearQueues() { | ||
| bool AnyQueuesCleared = false; | ||
| for (auto &Queue : MRecordingQueues) { | ||
| void graph_impl::clearQueues(bool NeedsLock) { |
Contributor
Author
There was a problem hiding this comment.
the intention is to avoid lock of queue_impl::MMutex (setCommandGraph) under graph_impl::MMutex lock since we have exact reverse order lock in submission path.
|
|
||
| void setCommandGraphUnlocked( | ||
| std::shared_ptr<ext::oneapi::experimental::detail::graph_impl> Graph) { | ||
| const std::shared_ptr<ext::oneapi::experimental::detail::graph_impl> |
Contributor
Author
There was a problem hiding this comment.
fixing "copy instead of move"
Contributor
|
Some of these changes seem to overlap with #20614. |
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
|
@intel/sycl-graphs-reviewers kindly ping, could you please provide feedback on graph related changes? |
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
vinser52
reviewed
Nov 13, 2025
vinser52
reviewed
Nov 13, 2025
vinser52
approved these changes
Nov 13, 2025
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.