[SYCL] Drop kernel name type backward compatibility #20713
+86
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergey-semenov
requested review from
a team,
aelovikov-intel and
cperkinsintel
as code owners
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Comment on lines
530
to
+532
| #ifndef __INTEL_PREVIEW_BREAKING_CHANGES | ||
| /// \return a string containing name of SYCL kernel. | ||
| detail::ABINeutralKernelNameStrT getKernelName(); | ||
| detail::string_view getKernelName(); |
Contributor
There was a problem hiding this comment.
Why aren't you dropping this entire #ifndef?
| std::vector<detail::LocalAccessorImplPtr> MLocalAccStorage; | ||
| std::vector<std::shared_ptr<detail::stream_impl>> MStreamStorage; | ||
| detail::ABINeutralKernelNameStrT MKernelName; | ||
| detail::string_view MKernelName; |
Contributor
There was a problem hiding this comment.
Suggested change
| detail::string_view MKernelName; | |
| // std::string_view ABI differs under `-D_GLIBCXX_USE_CXX11_ABI=0`, | |
| // use our implementation: | |
| detail::string_view MKernelName; |
| // possible. | ||
| #endif | ||
| decltype(auto) KernelName = KernelNameStrRefT{DeviceKernelInfo.Name}; | ||
| decltype(auto) KernelName = std::string_view{DeviceKernelInfo.Name}; |
Contributor
There was a problem hiding this comment.
Suggested change
| decltype(auto) KernelName = std::string_view{DeviceKernelInfo.Name}; | |
| std::string_view KernelName = DeviceKernelInfo.Name; |
| auto [Iter, Inserted] = | ||
| m_DeviceKernelInfoMap.try_emplace(KernelNameStrT{Info.Name.data()}, Info); | ||
| auto [Iter, Inserted] = m_DeviceKernelInfoMap.try_emplace( | ||
| std::string_view{Info.Name.data()}, Info); |
Contributor
There was a problem hiding this comment.
I had tried to add detail::string_view::operator std::string_view but it resulted in ambiguities with some comparison operators (I think). Now that we can remove old ones, maybe a better fix would be to change detail::string_view to have this conversion and rely on it happening implicitly for comparisons.
| size_t size() const { return MDeviceGlobals.size(); } | ||
|
|
||
| size_t count(const KernelNameStrT &UniqueId) const { | ||
| size_t count(const std::string_view &UniqueId) const { |
Contributor
There was a problem hiding this comment.
Why const reference?
| #include <sycl/detail/kernel_name_str_t.hpp> | ||
| #include <sycl/kernel_bundle.hpp> | ||
|
|
||
| #include <cstring> |
Contributor
There was a problem hiding this comment.
I'm somewhat surprised we need this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.