Skip to content

Conversation

@dyniols
Copy link
Contributor

@dyniols dyniols commented Nov 20, 2025

This PR removes std::runtime_error that dimensionality of cluster, global and local ranges must be same.

I don't think that this should be restriction. I can't find anything in https://docs.nvidia.com/cuda/cuda-c-programming-guide/#thread-block-clusters

Here is spec for extension: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_codeplay_cuda_cluster_group.asciidoc

@dyniols
Copy link
Contributor Author

dyniols commented Nov 20, 2025

It's idea and I would like to hear your opinions if we can remove that std::runtime_error for cuda cluster?

@dyniols dyniols requested a review from gmlueck November 20, 2025 19:41
@dyniols dyniols changed the title [SYCL] Remove std::runtime_error that dimensionality of cluster, global and local ranges must be same [SYCL] Remove std::runtime_error that dimensionality of cluster, global and local ranges must be same for sycl_ext_codeplay_cuda_cluster_group extension Nov 20, 2025
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like the extension mandated this exception and even if it did it shouldn't be an std::runtime_error but some sycl::exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants