Skip to content

[SYCL][L0 v2] Fix bindless array image subregion copies #20952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mateuszpn wants to merge 11 commits into
base: sycl
Choose a base branch
from
Open

[SYCL][L0 v2] Fix bindless array image subregion copies #20952

mateuszpn wants to merge 11 commits into from
+33 −36

Conversation

@mateuszpn
Copy link
Contributor

@mateuszpn mateuszpn commented Dec 22, 2025

Fix bindless array image subregion copies on Level Zero v2 (SYCL validation + UR region mapping)
Enable tests (previously failing and disabled with no tracking):
bindless_images/array/read_write_1d_subregion.cpp
bindless_images/array/read_write_2d_subregion.cpp

@mateuszpn mateuszpn changed the title Fix bindless array image subregion copies on Level Zero v2 (SYCL vali… Fix bindless array image subregion copies Dec 22, 2025
@mateuszpn mateuszpn changed the title Fix bindless array image subregion copies [SYCL][L0 v2] Fix bindless array image subregion copies Dec 22, 2025
pbalcer
pbalcer reviewed Jan 7, 2026
View reviewed changes
unified-runtime/source/adapters/level_zero/image_common.cpp Outdated
} else if (ZeImageDesc.type == ZE_IMAGE_TYPE_2D ||
ZeImageDesc.type == ZE_IMAGE_TYPE_2DARRAY) {
Region->depth = 1;
// Runtime validation of Origin values based on image type
Copy link
Contributor

@pbalcer pbalcer Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit, I'm not super well versed in image support in L0. Can you describe what the change is, and why it fixes the problem?

Copy link
Contributor Author

@mateuszpn mateuszpn Jan 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is simplified now. Still, basically the change in level_zero adapter code fixes mapping of image region dimensions which is different in UR and L0 for 1DARRAY images. In particular, numbers of layers to copy in UR: Region-depth, L0: Height. Starting index UR: Origin->z, L0: OriginY

Copy link
Contributor Author

@mateuszpn mateuszpn Jan 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also 1D images need adjusting - UR allows Height and Depth to be 0 (only Width set to image size), while L0 needs them to be 1.

@mateuszpn mateuszpn marked this pull request as ready for review January 22, 2026 14:04
@mateuszpn mateuszpn requested review from a team as code owners January 22, 2026 14:04
@mateuszpn mateuszpn requested a review from slawekptak January 22, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbalcer pbalcer pbalcer left review comments

@slawekptak slawekptak Awaiting requested review from slawekptak slawekptak is a code owner automatically assigned from intel/llvm-reviewers-runtime

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mateuszpn @pbalcer