[SYCL][UR][L0] Add UR_L0 environment variables#8732
Conversation
3a3b932 to
99bd6dc
Compare
|
@smaslov-intel : please review. |
There was a problem hiding this comment.
Seems we need a way to determine if this code is being executed as part of L0 PI or L0 UR adapter. One way to do it would be to add a compile define into cmake that is only set when compiling the adapater library, check it in this file and route calls accordingly.
There was a problem hiding this comment.
@bmyates: we could, but that would be short-termed since idea is that there's no PI+L0 anymore but PI+URL0, if I'm not mistaken. This is how the prints look like now with this change:
$ UR_L0_DEBUG=1 SYCL_PI_TRACE=2 <app>
...
---> piKernelRelease(
<unknown> : 0x2a78f10
ZE ---> zeKernelDestroy(Kernel->ZeKernel)
UR ---> urProgramRelease(KernelProgram)
) ---> pi_result : PI_SUCCESS
...
sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero_common.cpp
Outdated
Show resolved
Hide resolved
sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero_common.hpp
Outdated
Show resolved
Hide resolved
sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero_common.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Similarly, have UR_L0_SERIALIZE take precedence
sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero_common.hpp
Outdated
Show resolved
Hide resolved
99bd6dc to
964ab4f
Compare
|
@smaslov-intel Rebased and introduced some of the suggestions. |
LGTM. Please avoid rebase if not strictly necessary. It allows for incremental reviews. |
6734945 to
69fd501
Compare
|
@smaslov-intel : incremental changes on third commit: 69fd501 |
|
Failing on CUDA with Seems like it is being fixed in #8860 |
69fd501 to
dfb96f7
Compare
|
Rebased needed to include #8860 |
|
@jandres742, could you resolve merge conflicts, please? |
dfb96f7 to
471b56b
Compare
Define UR_LO_DEBUG and UR_L0_SERIALIZE, and keep their ZE_ counterparts for now. And do some reorganization Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
471b56b to
1c9a1af
Compare
Update to oneapi-src/unified-runtime@d6af758 Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
Thanks @bader . Rebased. |
|
only failure is still Reported in #8847 @intel/llvm-gatekeepers : could we merge this, to avoid further delays and rebases? |
Define UR_LO_DEBUG and UR_L0_SERIALIZE, and keep their ZE_ counterparts for now. And do some reorganization --------- Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
Define UR_LO_DEBUG and UR_L0_SERIALIZE, and keep
their ZE_ counterparts for now.
And do some reorganization