Skip to content

[Encode] VP9 Encode Add boundary check for log2_tile_columns #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Encode] VP9 Encode Add boundary check for log2_tile_columns #1964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions media_softlet/linux/common/codec/ddi/enc/media_libvpx_vp9_next.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,18 @@ bool Vp9WriteUncompressHeader(encode::DDI_ENCODE_CONTEXT *ddiEncContext,
min_log2_tile_cols = get_min_log2_tile_cols(sb_cols);
max_log2_tile_cols = get_max_log2_tile_cols(sb_cols);

if (picParam->log2_tile_columns < min_log2_tile_cols)
{
// This is boundary checking for log2_tile_columns. We should not hit this
// If user passes right log2_tile_columns.
// Making log2_tile_columns as min_log2_tile_cols to avoid negative col_data.
DDI_CODEC_ASSERTMESSAGE("log2_tile_columns (%d) < min_log2_tile_cols (%d), adjusting to minimum. \n",
picParam->log2_tile_columns, min_log2_tile_cols);
picParam->log2_tile_columns = min_log2_tile_cols;
}

col_data = picParam->log2_tile_columns - min_log2_tile_cols;

while (col_data--)
{
vp9_wb_write_bit(wb, 1);
Expand Down