[XeTileToXeGPU] add slm support for the lowering of load_tile/store_tile#1015
Merged
[XeTileToXeGPU] add slm support for the lowering of load_tile/store_tile#1015
Conversation
Garra1980
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds lowering support for optimal SLM access. The optimal SLM access is defined as:
tileShape[1] % 16 == 0
slmShape[0] % tileShape[0] == 0
slmShape[1] % tileShape[1] == 0
TileOffset[0] % tileShape[0] == 0
TileOffset[1] % tileShape[1] == 0
regular tile (tile without order attribute)
tileShape[0] x tileShape[1] % 64 == 0 (in bytes) to work
tileShape[0] x tileShape[1] % 256 == 0 (in bytes) for best performance
transposed tile (tile with order attribute)
tileShape[0] % vnni == 0 to work
tileShape[0] % (8 * vnni) == 0 for best performance.
The shape of all uses (init_tile) of the SLM meet the above conditions at the same time.
store/load_tile on regular SLM tile is lowered into 1D xegpu block store_nd/load_nd.
store_tile on transposed SLM tile is lowered into xegpu store_scatter
load_tile on transposed SLM tile is not supported yet, since we don't have a case requiring it.
update_tile_offset on SLM tileType is not also supported, since we don't have a case requiring it.
It also updated the fallback to skip the optimal SLM access and fixed an issue in WgToSg.
Please review these guidelines to help with the review process: