Skip to content

[Blocking] Emulate the unpack and pack on vectors using insert_strided_slice and extract_strided_slice#1023

Merged
chencha3 merged 1 commit intomainfrom
packAndUnpack_for_upstream
Feb 14, 2025
Merged

[Blocking] Emulate the unpack and pack on vectors using insert_strided_slice and extract_strided_slice#1023
chencha3 merged 1 commit intomainfrom
packAndUnpack_for_upstream

Conversation

@chencha3
Copy link
Copy Markdown
Contributor

This PR replaces unpack op for Vectors with insert_strided_slice
and pack op for vectors with extract_strided_slice. This would have
some performance penalty for a few tests, but matchs the upstream
implementation, and we can reuse patterns from upstream for, e.g., vectorizable ops

Please review these guidelines to help with the review process:

  • Have you provided a meaningful PR description?
  • Have you added a test, a reproducer, or a reference to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?
  • Have you organized your commits logically and ensured each can be built by itself?

@chencha3 chencha3 merged commit ab01f17 into main Feb 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants