[GPUToSPIRV][BF16] Handle single element vector case for bf16 emulation.#1024
Merged
mshahneo merged 3 commits intointel:mainfrom Feb 18, 2025
Merged
Conversation
bf16 emulation requires that we match certain op patterns created
by the bf16-to-gpu pass and insert Intel BF16 SPIR-V convert op
in the GPUToSPIRV pass.
However, previously, single-element vector was not supported.
This patch adds the support.
Remove imex-remove-single-elem-vector from the pipeline.
Add upstream single element vector{load|store} handling patch.
This patch should be removed in next LLVM version update.
Garra1980
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bf16 emulation requires that we match certain op patterns created by the bf16-to-gpu pass and insert Intel BF16 SPIR-V convert op in the GPUToSPIRV pass.
However, previously, single-element vector was not supported. This patch adds the support.
Remove imex-remove-single-elem-vector from the pipeline.
Add upstream single element vector{load|store} handling patch. This patch should be removed in next LLVM version update.
Please review these guidelines to help with the review process: