Skip to content

[GPUToSPIRV][BF16] Handle single element vector case for bf16 emulation.#1024

Merged
mshahneo merged 3 commits intointel:mainfrom
mshahneo:single_elem_vector_load_store_for_upstream
Feb 18, 2025
Merged

[GPUToSPIRV][BF16] Handle single element vector case for bf16 emulation.#1024
mshahneo merged 3 commits intointel:mainfrom
mshahneo:single_elem_vector_load_store_for_upstream

Conversation

@mshahneo
Copy link
Copy Markdown
Contributor

@mshahneo mshahneo commented Feb 18, 2025

bf16 emulation requires that we match certain op patterns created by the bf16-to-gpu pass and insert Intel BF16 SPIR-V convert op in the GPUToSPIRV pass.

However, previously, single-element vector was not supported. This patch adds the support.

Remove imex-remove-single-elem-vector from the pipeline.

Add upstream single element vector{load|store} handling patch. This patch should be removed in next LLVM version update.

Please review these guidelines to help with the review process:

  • Have you provided a meaningful PR description?
  • Have you added a test, a reproducer, or a reference to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?
  • Have you organized your commits logically and ensured each can be built by itself?

bf16 emulation requires that we match certain op patterns created
by the bf16-to-gpu pass and insert Intel BF16 SPIR-V convert op
in the GPUToSPIRV pass.

However, previously, single-element vector was not supported.
This patch adds the support.

Remove imex-remove-single-elem-vector from the pipeline.

Add upstream single element vector{load|store} handling patch.
This patch should be removed in next LLVM version update.
@mshahneo mshahneo requested a review from Garra1980 February 18, 2025 15:31
@mshahneo mshahneo merged commit ae189fc into intel:main Feb 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants