Skip to content

Conversation

drprajap
Copy link
Contributor

@drprajap drprajap commented Nov 3, 2022

GPUXToSPIRV pass is just extension to upstream GPUTOSPIRV pass, it does not use with GPUX dialect, so this patch is correcting the misleading pass name.

Please review these guidelines to help with the review process:

  • Have you provided a meaningful PR description?
  • Have you added a test, a reproducer, or a reference to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?
  • Have you organized your commits logically and ensured each can be built by itself?

@nbpatel
Copy link
Contributor

nbpatel commented Nov 4, 2022

ConvertGPUToSPIRVDialectPass maybe? SPIRVExt seems a little misleading

@drprajap
Copy link
Contributor Author

drprajap commented Nov 8, 2022

ConvertGPUToSPIRVDialectPass maybe? SPIRVExt seems a little misleading

yes SPIRVExt seems confusing, have to think about other name, I have not seen somethingDialectPass for conversion passes, but will check in upstream and see.

@silee2 silee2 changed the base branch from refactor to main December 14, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants