OVEP V4.0 Updates #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayavijx
commented
Apr 4, 2022
mayavijx
commented
- Updated README documents.
- Updated csharp sample with latest ImageSharp API
- Updated cpp samples with nchw changes
MaajidKhan
reviewed
Apr 4, 2022
c_cxx/OpenVINO_EP/Windows/README.md
Outdated
| Choose required opencv path. Skip the opencv flag if you don't want to build squeezenet sample. | ||
| **Note:** | ||
| If you are using the opencv from openvino package, below are the paths: | ||
| * For latest version (2022.1.0), run download_opencv.ps1 in \path\to\openvino\extars\script and the opencv will be downloaded at \path\to\openvino\extars. |
There was a problem hiding this comment.
Pls correct the spellings.
1.download_opencv.sh
2.\extras (At 2 places)
Author
There was a problem hiding this comment.
Corrected typo error at \extras. download_opencv.ps1 is correct as it is a powershell script in Windows.
MaajidKhan
reviewed
Apr 4, 2022
| ``` | ||
| **Note:** | ||
| If you are using the opencv from openvino package, below are the paths: | ||
| * For latest version (2022.1.0), run download_opencv.sh in /path/to/openvino/extars/script and the opencv will be downloaded at /path/to/openvino/extars. |
There was a problem hiding this comment.
correct the spelling here
1./extras (At 2 places)
MaajidKhan
reviewed
Apr 5, 2022
c_cxx/OpenVINO_EP/Windows/README.md
Outdated
| Choose required opencv path. Skip the opencv flag if you don't want to build squeezenet sample. | ||
| **Note:** | ||
| If you are using the opencv from openvino package, below are the paths: | ||
| * For latest version (2022.1.0), run download_opencv.ps1 in \path\to\openvino\extras\script and the opencv will be downloaded at \path\to\openvino\extras. |
There was a problem hiding this comment.
download_opencv.ps1 should be download_opencv.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.