Update OptTable due to llvm commit fdbd17d1fb0d5 #582
Merged
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUBCOMMANDIDS_OFFSET is newly introduced in llvm/llvm-project@fdbd17d1fb0d5
There was a problem hiding this comment.
Pull Request Overview
Updates OptTable macro definitions to accommodate a new parameter introduced in LLVM commit fdbd17d1fb0d5.
- Adds SUBCOMMANDIDS_OFFSET parameter to OPTION macro definitions
- Updates both the macro definition and its usage in the ClangOptionsInfoTable
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| options_compile.cpp | Adds SUBCOMMANDIDS_OFFSET parameter to OPTION macro and includes it in the ClangOptionsInfoTable initialization |
| options.h | Updates OPTION macro definition to include SUBCOMMANDIDS_OFFSET parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@wenju-he , There is a build failure. Please take a look. Thanks. |
will be fixed by KhronosGroup/SPIRV-LLVM-Translator#3385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUBCOMMANDIDS_OFFSET is newly introduced in llvm/llvm-project@fdbd17d1fb0d5