Skip to content

Push 2026 02 20#1002

Merged
opcm merged 81 commits intomasterfrom
push-2026-02-20
Feb 21, 2026
Merged

Push 2026 02 20#1002
opcm merged 81 commits intomasterfrom
push-2026-02-20

Conversation

@rdementi
Copy link
Copy Markdown
Contributor

@rdementi rdementi commented Feb 21, 2026

No description provided.

markovamaria and others added 30 commits January 26, 2026 13:51
@markovamaria @rdementi
SDL330: Add O_NOFOLLOW symlink protection to pcm-msr.cpp, client.cpp,…
a59de68 
… mmio.cpp
@rdementi
Implement Windows MCFG ACPI table reading using GetSystemFirmwareTabl…
c1cc5d0 
…e API

Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
@rdementi
Address code review feedback: improve comments and fix alignment issue
5360074 
Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
@rdementi
Add security validation for MCFG header length to prevent integer und…
dc8f74e 
…erflow

Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
@rdementi
fix compilation on Windows
56b6291 
Change-Id: I8ffe662a1ba9e878a5488fca45fd7476a06244aa
@rdementi
convert PCM_DEBUG ifdef into DBG messages
afdebfc 
Change-Id: I173d8cd2da9f85b62a6684b6e30b2f0049448480
@rdementi
Add getNUMANode() API to PciHandle and PciHandleMM classes
7aab6aa 
Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
@rdementi
Refactor getNUMANode to use shared helper function
e88e116 
Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
@rdementi
Address code review feedback: improve comments and formatting
7ae883b 
Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
@rdementi
Add implementation summary document
9e32b3d
@rdementi
Implement Windows NUMA node retrieval using ACPI SRAT table
400eca6 
Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
@rdementi
Improve Windows NUMA implementation: add thread safety and fix alignment
79f564b 
Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
@rdementi
Implement FreeBSD NUMA node retrieval using sysctl
124697e 
Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
@rdementi
Improve FreeBSD implementation: add buffer overflow protection
dac100c 
Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
@rdementi
Add -n option to pcm-pcicfg to print NUMA node of PCI device
0f34ec7 
Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
@rdementi
Add tests for pcm-pcicfg -n option to test.sh for CI
98bf5e5 
Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
@rdementi
fix compilation issues
436760f 
Change-Id: I9afcc59f91eb56c2415d3d4e424c7df08b8e31d3
@rdementi
improve formatting
48daab8 
Change-Id: I0fc5e21c913f05bae0d56fc2598556979ca7da59
@rdementi
address cppcheck false-positive
7e052ed 
Change-Id: Icb5a2564abdc1b8277d6dafa7a65f7707782e696
@rdementi
remove a too detailed implementation summary
e8103c8 
Change-Id: I2eeca4ecf9fdb2fea595a59acf207b18d32802dd
@rdementi
DBG: print NUMA node in PCICFG register scan
1d702ce 
Change-Id: Ib0497e29ecad2f0621e2c9bf272fd67fe9c45a45
@rdementi
pcm-power: more error checking anf DBG logging for PERF_LIMIT_REASON_…
19e4b2e 
…TPMI

Change-Id: I67c7664aedf697e723059dc44f476e5ac8a5c95e
@rdementi
DBG output for tpmi
c96f16f 
Change-Id: I67fddc841a6ac6d2cb6ce920e875644fa6657d32
@rdementi
Add API to map NUMA node ID to CPU socket ID
2d4dea8 
Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
@rdementi
Fix code review issues: update copyright years and improve Windows im…
51de67a 
…plementation

Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
@rdementi
Add FreeBSD implementation for mapNUMANodeToSocket API
d05ea64 
Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
@rdementi
remove FreeBSD fallback implementation which assumes NUMA domain == s…
66d3652 
…ocket

Change-Id: Ib856d2d380427ee5003979c1b4ec587a7c52bce6
@rdementi
pass NUMANode to uncore discovery and TPMI detection function
b9d42da 
Change-Id: Icdce6a476726b307922c33c64d1925015688c8d7
@rdementi
don't assume 1 discovery table per socket, instead use NUMA topology …
f5486cf 
…APIs

Change-Id: Ibceda4ae293af7ae23e1f05ce4e83c7958ba72a9
@rdementi
document socket 0 as default
9b92681 
Change-Id: Ibdcf65ca555959edec3e66beb9dd3a1e84feedcf
rdementi and others added 11 commits February 6, 2026 12:25
@rdementi
rework verbosity levels
ea6317b 
Change-Id: I7c8ad1ec68bfabe640550f2bc1892f109128a093
@markovamaria @rdementi
Update Intel-PMT to latest (8e57e18)
83cb106
@markovamaria @rdementi
Removed details from error message (SDL423 compliance)
2c8f336
@markovamaria @rdementi
Add SDL441 compliance workflow with CAS integration
3c29ebe 
- Implement Software Composition Analysis (SDL441) scanning
- Configure CAS orchestrator with SDL API
- Add workflow triggers: manual run, scheduled (every 60 days)
- Configure secrets: SDL_API_KEY, SDL_PROJECT_ID, SDL_IDSID_VALUE
- Auto loading of evidence to SDL task and SDL task status update is presented
@markovamaria @rdementi
Update Dockerfile to meet security compliance
209bb48
@markovamaria @rdementi
Add SDL419 compliance workflow with CAS integration
9b55b8a
@markovamaria @rdementi
Enabled automatic evidence submission for SDL441
41faa0b
@markovamaria @rdementi
Harden DLL loading, enable SSL for pcm-sensor-server on Windows CI
6936bfd 
Security:
- Add SetDefaultDllDirectories(LOAD_LIBRARY_SEARCH_SYSTEM32) to PCM_SET_DLL_DIR
  macro in utils.h to prevent DLL planting attacks (CWE-427)
- Update WINDOWS_HOWTO.md with DLL planting prevention guidance

SSL enablement:
- Set OPENSSL_ROOT_DIR and pass LIB_EAY_RELEASE/SSL_EAY_RELEASE to CMake so
  FindOpenSSL locates the static libraries in lib/VC/x64/MT/
- Remove premature include(FindOpenSSL) from src/CMakeLists.txt
- Link crypt32 and ws2_32 on MSVC for static OpenSSL dependencies
@rdementi
fix FreeBSD build
28d60a9 
Change-Id: I378726c9d6db78108ae363d7d585cea93ccbfebb
@rdementi
Revert "fix FreeBSD build"
7b7ff20 
This reverts commit 28d60a9.
@rdementi
add a missing include file
7f67bdb 
Change-Id: I8b133c79543e355e3c4bd3f490368fe465d21685
@rdementi
Copy link
Copy Markdown
Contributor Author

rdementi commented Feb 21, 2026

@copilot fix this compilation error on FreeBSD: /usr/include/sys/domainset.h:122:5: note: candidate function not viable: no known conversion from 'cpuset_t *' (aka '_cpuset *') to 'domainset_t *' (aka '_domainset *') for 5th argument
122 | int cpuset_getdomain(cpulevel_t, cpuwhich_t, id_t, size_t, domainset_t *,
| ^ ~~~~~~~~~~~~~

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 21, 2026

@rdementi I've opened a new pull request, #1003, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI mentioned this pull request Feb 21, 2026
Merged
@rdementi
Fix FreeBSD compilation error: use cpuset_getaffinity instead of cpus…
11cc76c 
…et_getdomain

Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
@rdementi
Copy link
Copy Markdown
Contributor Author

rdementi commented Feb 21, 2026

@copilot fix this error on OSX/MacOS: In file included from /Users/runner/work/pcm/pcm/examples/numa_to_socket_example.cpp:7:
In file included from /Users/runner/work/pcm/pcm/examples/../src/cpucounters.h:28:
/Users/runner/work/pcm/pcm/examples/../src/msr.h:20:10: fatal error: 'MSRAccessor.h' file not found
20 | #include <MSRAccessor.h>
| ^~~~~~~~~~~~~~~
1 error generated.

Copilot AI mentioned this pull request Feb 21, 2026
Merged
Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 21, 2026

@rdementi I've opened a new pull request, #1004, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 10 commits February 21, 2026 15:10
@rdementi
Fix macOS build: add MacMSRDriver include path for numa_to_socket_exa…
f322751 
…mple

Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
@rdementi
don't compile NUMA example on OSX
0eb084b 
Change-Id: Ib8554db69242d44bff638e37a273928ce2bd92c9
@rdementi
try to fix compile error
db8416f 
Change-Id: I979a613a2f415b274455fa5e65f1e98af99bba05
@rdementi
fix cppcheck warning
8d0e56e 
Change-Id: I8b9f6b9a0e57888e1a5b921e8fc9ddb372d454c3
@rdementi
fix compilation error
609a6e8 
Change-Id: Ifa1f7270041369f225c97c971d03f87ce473763f
@rdementi
alternative BitScanForward64 implementation
1f1418a 
Change-Id: I1d2f388da8414c6cf9401141dfa8e924f6677fd8
@rdementi
no numa test on OSX
cf1898e 
Change-Id: Ief9b010cf38cf4cc835732e39d497b8cf2e997ae
@rdementi
address cppcheck false-positive
677543d 
Change-Id: I3c92ba93a6023bb02780ec4ff7b87d8963cead2c
@rdementi
fix cmake file
8256278 
Change-Id: Ic579b26276798d2bb2ce33c05dc8cf7019c38d3c
@rdementi
do not build numa cache test on OSX
786225b 
Change-Id: Ia9af69f33e2a5aa20b9175d6bbf54fe39b29788b
@opcm opcm merged commit 1f22144 into master Feb 21, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opcm opcm opcm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rdementi @opcm @markovamaria