Merged
Conversation
…_lspci.h branch here
…plit-pcm-iio.cpp in here
…sor-server_output
Delete the duplication from pcm-iio.cpp and its copies pcm-iio-pmu.{h,cpp}
Delete the duplciation from lspci.h and its lspci.cpp copy
Change one tab into spaces in pcm-pcie.cpp
Reorganize the initialization of iio structures into a central function for reuse in pcm-iio-pmu
(Kept as part of this big change to try and preserve as much of the blame history as possible)
Use this central function in pcm-iio and pcm-sensor-server
Cleanup exiting pcm-sensor-server
Change-Id: I15bee4b6af87d6916f13aa1aedaa27a3de16495f
Change-Id: I8fbb846fa22aa31af1e9b9ea2ec1f61d9fa9de77
Change-Id: Ie5a217b153988372839520e3646c0f17bcd79c4b
Change-Id: I5df45bbc697f09a939420e225d942ad175b2fa31
Change-Id: Idffcdf4528b59dd6bf9c4c35db6957b472ccc67b
Fix a typo in pci.h
…m-sensor-server_output Add pci counters to pcm sensor server output
Change-Id: I637704cfc5c940abe42bf040afe38110a89a9533
Change-Id: I34fd631179283776c7c78c0381af5e7ffd2afc59
Change-Id: Id6245138048a0557b22bdcf75eecb14575ef40a0
Change-Id: I0154592b751089ff093f59d1df1bbdab81a4110b
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates documentation for improved clarity and consistency in Windows instructions and adds a new section demonstrating the usage of the "pcm-raw -?" command for listing processor events.
- Updated capitalization and phrasing in doc/WINDOWS_HOWTO.md for consistency.
- Added a command example section in doc/PCM_RAW_README.md.
Reviewed Changes
Copilot reviewed 6 out of 15 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| doc/WINDOWS_HOWTO.md | Corrected case and punctuation in driver and command details. |
| doc/PCM_RAW_README.md | Added a command example section to show available processor events. |
Files not reviewed (9)
- perfmon: Language not supported
- src/CMakeLists.txt: Language not supported
- src/cpucounters.cpp: Language not supported
- src/cpucounters.h: Language not supported
- src/lspci.cpp: Language not supported
- src/lspci.h: Language not supported
- src/pci.h: Language not supported
- src/pcm-raw.cpp: Language not supported
- src/pcm-sensor-server.cpp: Language not supported
opcm
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.