Skip to content

compile with c++17 features#941

Merged
rdementi merged 1 commit intomasterfrom
rdementi-cpp-17
Apr 23, 2025
Merged

compile with c++17 features#941
rdementi merged 1 commit intomasterfrom
rdementi-cpp-17

Conversation

@rdementi
Copy link
Copy Markdown
Contributor

No description provided.

@opcm opcm requested a review from Copilot April 22, 2025 16:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the code to require C++17 by replacing deprecated std::bind1st calls with std::bind using std::placeholders, modernizing the whitespace trimming in the HTTPHeader class.

  • Updated the leading and trailing whitespace removal logic in HTTPHeader::splitHeaderValue.
  • Enhances compliance with C++17 standards.
Files not reviewed (1)
  • CMakeLists.txt: Language not supported

@rdementi rdementi requested a review from ogbrugge-work April 22, 2025 18:21
@ogbrugge
Copy link
Copy Markdown
Contributor

I created a pull request which uses a lambda instead of using std::bind and this also works with g++ 7.5.0. Not sure where c++17 support starts though. Is there a particular reason for wanting c++17 support?

@rdementi
Copy link
Copy Markdown
Contributor Author

thank you @ogbrugge I will take your patch (it is more readable). g++ 7.5.0 supports many of c++17 features AFAIK, but not all. This should be enough for now. c++17 can help to simplify/reduce (new) code. I wanted to use std::variant for code implementing a new feature request.

@opcm opcm requested a review from Copilot April 23, 2025 06:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • CMakeLists.txt: Language not supported

@opcm opcm changed the title require c++17 compile with c++17 features Apr 23, 2025
@ogbrugge
Copy link
Copy Markdown
Contributor

Approved, using the wrong account here so can’t make it official

@rdementi rdementi merged commit 95ae120 into master Apr 23, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants