Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the code to require C++17 by replacing deprecated std::bind1st calls with std::bind using std::placeholders, modernizing the whitespace trimming in the HTTPHeader class.
- Updated the leading and trailing whitespace removal logic in HTTPHeader::splitHeaderValue.
- Enhances compliance with C++17 standards.
Files not reviewed (1)
- CMakeLists.txt: Language not supported
|
I created a pull request which uses a lambda instead of using std::bind and this also works with g++ 7.5.0. Not sure where c++17 support starts though. Is there a particular reason for wanting c++17 support? |
|
thank you @ogbrugge I will take your patch (it is more readable). g++ 7.5.0 supports many of c++17 features AFAIK, but not all. This should be enough for now. c++17 can help to simplify/reduce (new) code. I wanted to use std::variant for code implementing a new feature request. |
f13587e to
d531578
Compare
|
Approved, using the wrong account here so can’t make it official |
No description provided.