Push 2025 04 26

[rdementi]

No description provided.

[Copilot]

Pull Request Overview

This PR introduces a few updates: a guard condition was added in the dashboard code to ensure proper loop execution, a clang analyzer exclusion was applied to avoid false positives in CPU counters, and the CI workflow was updated to use the newer scan-build-18 command.

• Updated dashboard loop condition to check for valid UPI links.
• Wrapped a section in cpucounters.cpp with a clang analyzer guard.
• Modified CI configuration to use scan-build-18.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/dashboard.cpp	Added an extra condition in the for loop to check NumUPILinksPerSocket.
src/cpucounters.cpp	Added preprocessor guards to exclude code during clang analysis.
.github/workflows/ci-clang-scan.yml	Updated the scan-build command to scan-build-18.

[Copilot]

The additional check '&& NumUPILinksPerSocket > 0' in the loop condition may cause the loop to be skipped entirely if NumUPILinksPerSocket is 0. To improve clarity and avoid potential unintended behavior, consider verifying NumUPILinksPerSocket before entering the loop.

Suggested change

	for (size_t s = 0; s < NumSockets && NumUPILinksPerSocket > 0; ++s)
	{
	const auto S = std::to_string(s);
	if (NumUPILinksPerSocket > 0)
	{
	for (size_t s = 0; s < NumSockets; ++s)
	{
	const auto S = std::to_string(s);