Skip to content

[UNITRACE] Fix CID 723248 invalid iterator dereference in ZeMetricProfiler #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lennin-cp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[UNITRACE] Fix CID 723248 invalid iterator dereference in ZeMetricProfiler #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tools/unitrace/src/levelzero/ze_metrics.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,6 +1156,9 @@ class ZeMetricProfiler {
}
}
value += samples[i];
if (kit == kinfo.end()) {
break;
}
Comment on lines 1158 to +1161
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check occurs after value += samples[i] at line 1158, but the iterator kit is used or incremented in the inner loop above. If kit was incremented to kinfo.end() in the inner loop and the code breaks from it, then continues to line 1158, there's a potential that kit might be dereferenced between the break point and this check. Verify that no dereference of kit occurs at line 1158 or ensure this check happens immediately after the inner loop before any potential use of kit.

Suggested change
value += samples[i];
if (kit == kinfo.end()) {
break;
}
if (kit == kinfo.end()) {
break;
}
value += samples[i];

Copilot uses AI. Check for mistakes.
}
}
}
Expand Down