Rewrite mma unit tests #557
Conversation
yuanhang-dev
force-pushed
the
yh/rewrite_mma
branch
from
03a8e4a to
6f44bc8
Compare
yuanhang-dev
force-pushed
the
yh/rewrite_mma
branch
from
6f44bc8 to
6e2a6ac
Compare
test/unit/cute/intel_xe/mma.cpp
Outdated
| MMA_Test<XE_8x16x32_S32S8S8S32_TT, 64, 64, 8, 16, 32, int8_t, int8_t, | ||
| int32_t>(512, 512, 256); | ||
| run_mma_test<XE_8x16x32_S32S8S8S32_TT, Shape<_2, _2, _1>, | ||
| decltype(Shape<_64, _64, _32>{}), int8_t, int8_t, int32_t>( |
There was a problem hiding this comment.
nit:
| decltype(Shape<_64, _64, _32>{}), int8_t, int8_t, int32_t>( | |
| Shape<_64, _64, _32>, int8_t, int8_t, int32_t>( |
| verify(m, n, k, h_A.data(), h_B.data(), h_C.data()); | ||
| template<typename MMAAtom, typename LayoutShape, typename ShapeMNK, | ||
| typename TA, typename TB, typename TC> | ||
| void run_mma_test(ShapeMNK shape_mnk, LayoutShape layout_shape) { |
There was a problem hiding this comment.
you should pass ShapeMNK and LayoutShape only either as argument or template argument not both. If you choose the first place the template arguments at the end so that they can be deduced. If you choose the 2nd remove the arguments.
test/unit/cute/intel_xe/mma.cpp
Outdated
| TEST(PVC_CuTe_Xe, MMA_XE_8x16x32_S32S8S8S32_TT) { | ||
| MMA_Test<XE_8x16x32_S32S8S8S32_TT, 64, 64, 8, 16, 32, int8_t, int8_t, | ||
| int32_t>(512, 512, 256); | ||
| run_mma_test<XE_8x16x32_S32S8S8S32_TT, Shape<_2, _2, _1>, |
There was a problem hiding this comment.
Is the intention that the two of those are the same? If not, why not?
If you tried to keep them it's wrong because e.g. MNK would need to be 512,512,256 not 64,64,32.
There was a problem hiding this comment.
The same shape, such as <512 512 256>, cannot be used here because it will throw an OUT OF RESOURCE error during compilation. Since this unit test only verifies the correctness of atom MMA, the shape size has been reduced.
There was a problem hiding this comment.
Where is the error coming from?
In general please document in the PR message any non-obvious changes unrelated to the main goal of the PR. Helps both with code review and with later understanding why code was changed.
Antonyvance
added
the
Tests
3 participants
No description provided.